Conversation
noritada
approved these changes
May 17, 2025
Owner
noritada
left a comment
noritada
left a comment
There was a problem hiding this comment.
Sorry for my late reply and thank you for the patch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR updates proj to 0.30.
The project I'm working on that uses
grib-rsalready enablesproj/bundled_proj. I would also like to take advantage of the fact that the newestproj-sysuseslibsqlite3-syswhich provides a similarbundledfeature.All tests passed when I ran
cargo test --workspace.I ran
cargo +nightly clippy --workspaceper the contribution guide. The version I'm using,clippy 0.1.88 (25cdf1f674 2025-04-28), identifies unrelated code issues that I mentioned over on #115.